perf(core): Don't rebuild columns and precompile cell templates each time data is changed #4428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pr. I'm going to defer this to the rest of the @angular-ui/grid to review. But I'll add my looks good to me. |
Added guard to prevent column set being rebuilt and cell templates being precompiled everytime grid data changes Fixes #4386
|
I've updated the commit message to match the guidelines, let me know if it's still incompatible. It makes good sense to defer this to the rest of the team. Although I checked myself, I'm still unsure whether anything relies on the column set being rebuilt each time the data changes! |
swalters
added a commit
that referenced
this pull request
Oct 2, 2015
perf(core): Don't rebuild columns and precompile cell templates each time data is changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4386
This is quite a nice performance improvement in grids that have rapidly updating data